Resolves #117 Attempts to retry failed mounts of bricks#118
Open
gonoph wants to merge 1 commit intogluster:masterfrom
Open
Resolves #117 Attempts to retry failed mounts of bricks#118gonoph wants to merge 1 commit intogluster:masterfrom
gonoph wants to merge 1 commit intogluster:masterfrom
Conversation
After the update in commit 2e2e284, gluster-setup.sh no longer attempts to mount failed bricks. * checks for the return codes 1, 2, and 4 which is fatal * logs successful mount * if unsuccessful, allows script to continue to attempt the retry logic below.
|
Can you have a look at #114? It should address the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #117
After the update in commit 2e2e284, gluster-setup.sh no longer attempts to mount failed bricks.
According to the man page RETURN CODE 1 is incorrect permissions or invocation (bad parameters). The previous commit attempted to only test for that error, which if continuing in the script logic allows the glusterd pod/container to attempt to identify the failed bricks, and try various tricks to mount them.
This change tests for RETURN CODE 1, 2, and 4 - which should cover most fatal errors, and still allow the script to attempt to mount failed bricks using the logic below that test.
Also, the test at the end:
works better than the
wc -l $GLUSTERFS_LOG_CONT_DIR/failed_bricksit replaces, as thewccommand appends the filename, which breaks the number test-gt. Therefore, thecat | wcsyntax works better aswcdoes not print the filename when used on stdin, and thus it does not break the-gttest.